Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update website content #1668

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Update website content #1668

merged 8 commits into from
Jan 15, 2025

Conversation

rileyhgrant
Copy link
Contributor

@rileyhgrant rileyhgrant commented Jan 6, 2025 •
edited
Loading

Updates website content

  • Adds 'human' to about page
  • Removes member of SAB who is no longer member
  • Adds 'tm' to gnomAD where relevant
  • Moves and edits Open Science Policy
  • Adds gnomAD videos FAQ
  • Adds "Federated gnomAD" page
  • Rework citations page (re-organize, add new papers, use component for reusable citation)
  • Updates the Team page - moves Steve to Alumni :(

@rileyhgrant rileyhgrant self-assigned this Jan 6, 2025
@rileyhgrant rileyhgrant force-pushed the jan-2025-content-updates branch 3 times, most recently from d62cb4a to 8e45535 Compare January 8, 2025 15:16
phildarnowsky-broad
phildarnowsky-broad reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@phildarnowsky-broad phildarnowsky-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of things I'm dubious about, I'm guessing you had good reasons for most or all of them but I'd like to understand the reasoning too.

browser/about/about.md Show resolved Hide resolved
browser/about/policies/terms.md Outdated Show resolved Hide resolved
browser/src/FederationPage.tsx Outdated Show resolved Hide resolved
browser/src/FederationPage.tsx Show resolved Hide resolved
browser/src/FederationPage.tsx Show resolved Hide resolved
browser/src/FederationPage.tsx Outdated Show resolved Hide resolved
@rileyhgrant
Copy link
Contributor Author

Heya @phildarnowsky-broad

Added two fixup commits

  • Removed the one unneccesary @ts-expect-error that was called out
  • Added alt text for the logos -- thanks for the catch!

@rileyhgrant rileyhgrant force-pushed the jan-2025-content-updates branch 4 times, most recently from c694d68 to f5262cf Compare January 9, 2025 22:47
@rileyhgrant
Copy link
Contributor Author

Just noting here that I'm waiting until Friday to merge this -- at that time at least one of the groups on the Federated page will have voted on a different name, so that text will have to change.

@rileyhgrant rileyhgrant force-pushed the jan-2025-content-updates branch 3 times, most recently from 4c1fc05 to f724340 Compare January 15, 2025 21:00
@rileyhgrant rileyhgrant force-pushed the jan-2025-content-updates branch from 9dd5c74 to 5ff29c3 Compare January 15, 2025 21:20
@rileyhgrant rileyhgrant merged commit 47db5c4 into main Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phildarnowsky-broad phildarnowsky-broad phildarnowsky-broad approved these changes

Assignees

@rileyhgrant rileyhgrant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rileyhgrant @phildarnowsky-broad